fix(aws_ecs): Do not output NetworkConfiguraiton to ECS Service when using EXTERNAL deployment controller #26338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deploy controller
…tput when with external deployment controller
…citly specifying a deployment controller type other than EXTERNAL
|
|
github-actions
bot
added
bug
aws-cdk-automation
added
the
pr/needs-community-review
mrgrain
approved these changes
Jul 14, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
colifran
pushed a commit
that referenced
this pull request
Jul 17, 2023
…using EXTERNAL deployment controller (#26338) When using an external deployment controller, ECS Service creation fails because the `NetworkConfiguration` is output to the template. This fix prevents the output of `NetworkConfiguration` when using external deployment controller. Closes #26335 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
msysh
deleted the
ecs-no-network-configuration-with-external-deploy-controller
branch
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this pull request
Jul 29, 2023
…using EXTERNAL deployment controller (aws#26338) When using an external deployment controller, ECS Service creation fails because the `NetworkConfiguration` is output to the template. This fix prevents the output of `NetworkConfiguration` when using external deployment controller. Closes aws#26335 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an external deployment controller, ECS Service creation fails because the
NetworkConfigurationis output to the template.This fix prevents the output of
NetworkConfigurationwhen using external deployment controller.Closes #26335
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license