Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): allow user to specify --platform #26368

Merged
merged 4 commits into from
Jul 14, 2023
Merged

feat(core): allow user to specify --platform #26368

merged 4 commits into from
Jul 14, 2023

Conversation

maafk
Copy link
Contributor

@maafk maafk commented Jul 14, 2023

Allowing user to provide a platform property when bundling docker assets (ref).

Currently, this is not possible when using an existing Docker image via the BundlingOptions. You can specify this when building a DockerImageAsset, but not when using an image as a builder:

Closes #25759.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jul 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 14, 2023 13:41
@github-actions github-actions bot added feature-request A feature should be added or improved. p1 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Jul 14, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@maafk
Copy link
Contributor Author

maafk commented Jul 14, 2023 •
edited

Clarification Request - Looking for existing integration tests that I can use as an example for this use case.

I figured I could create within aws-lambda (using the BundlingOptions with the platform option), but I'm not seeing any example integ tests within packages/aws-cdk-lib/aws-lambda/test that I can steal from.

Any advice on where I can steal good integ test code from?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jul 14, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 14, 2023
@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 14, 2023
@mrgrain mrgrain changed the title feat: allow user to specify --platform feat(core): allow user to specify --platform Jul 14, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 14, 2023 16:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: be95225
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2f8df43 into aws:main Jul 14, 2023
6 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@maafk maafk deleted the add-platform-option-to-bunding-options branch July 14, 2023 17:21
colifran pushed a commit that referenced this pull request Jul 17, 2023
@maafk @colifran
feat(core): allow user to specify --platform (#26368)
ae80ed4 
Allowing user to provide a `platform` property when bundling docker assets ([ref](https://docs.docker.com/build/building/multi-platform/)).

Currently, this is not possible when using an existing Docker image via the [BundlingOptions](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.BundlingOptions.html). You can specify this when building a  [DockerImageAsset](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecr_assets.DockerImageAsset.html#platform), but not when using an image as a builder:

Closes #25759.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@maafk @bmoffatt
feat(core): allow user to specify --platform (aws#26368)
fe2c067 
Allowing user to provide a `platform` property when bundling docker assets ([ref](https://docs.docker.com/build/building/multi-platform/)).

Currently, this is not possible when using an existing Docker image via the [BundlingOptions](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.BundlingOptions.html). You can specify this when building a  [DockerImageAsset](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecr_assets.DockerImageAsset.html#platform), but not when using an image as a builder:

Closes aws#25759.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(core): Allow passing platform via BundlingOptions
3 participants
@maafk @aws-cdk-automation @mrgrain