Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): cross region exports fail when parameter doesn't exist #26434

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

corymhall
Copy link
Contributor

The JavaScript SDK v3 handles errors differently than v2. This update was missed when we upgraded the code to SDK v3.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The JavaScript SDK v3 handles errors differently than v2. This update
was missed when we upgraded the code to SDK v3.
@github-actions github-actions bot added the p2 label Jul 19, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 19, 2023 14:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 19, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b5ca9ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d130bd7 into aws:main Jul 19, 2023
6 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
…s#26434)

The JavaScript SDK v3 handles errors differently than v2. This update was missed when we upgraded the code to SDK v3.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants