feat(route53): use sdk v3 / node 18 in CrossAccountZoneDelegationRecord
#26976
Assignees
Labels
@aws-cdk/aws-route53
Related to Amazon Route 53
feature-request
A feature should be added or improved.
node18-upgrade
Any work (bug, feature) related to Node 18 upgrade
p1
sdk-v3-upgrade
Tag issues that are associated to SDK V3 upgrade. Not limited to CR usage of SDK only.
Comments
scanlonp
added
p1
feature-request
mergify bot
pushed a commit
that referenced
this issue
Sep 5, 2023
…16 (#26980) Updates the `CrossAccountZoneDelegationRecord` construct to use sdk v3 / node 18. This is identical to changes in #26212, except for hardcoding a region into the `assumeRole` sdk call. This may not be the ideal solution, but should not break specific configurations. That specific configuration, as #26593 pointed out, was that the original update was a breaking change if the construct was deployed into an opt-in region, and the parent zone did not have that opt-in region enabled. This PR removes the semi-hidden `@aws-cdk/aws-route53:useRegionalStsEndpoint` feature flag, as it was based on a confusion on why things used to work. We now pick the correct endpoint manually. Closes #26976. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
mikewrighton
pushed a commit
that referenced
this issue
Sep 14, 2023
…16 (#26980) Updates the `CrossAccountZoneDelegationRecord` construct to use sdk v3 / node 18. This is identical to changes in #26212, except for hardcoding a region into the `assumeRole` sdk call. This may not be the ideal solution, but should not break specific configurations. That specific configuration, as #26593 pointed out, was that the original update was a breaking change if the construct was deployed into an opt-in region, and the parent zone did not have that opt-in region enabled. This PR removes the semi-hidden `@aws-cdk/aws-route53:useRegionalStsEndpoint` feature flag, as it was based on a confusion on why things used to work. We now pick the correct endpoint manually. Closes #26976. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
Route53's
CrossAccountZoneDelegationRecordstill uses the sdk v2 and node 16. We are moving all custom resources to sdk v3 and node 18 since node 16 is soon to be deprecated.Related to #26593 and #26666.
Use Case
Using constructs that create custom resources will now have them on the node 18 runtime.
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.93.0
Environment details (OS name and version, etc.)
Mac
The text was updated successfully, but these errors were encountered: