Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-stepfunctions-tasks: AthenaStartQueryExecution is missing ExecutionParameters #27286

Closed
1 of 2 tasks
nakedible-p opened this issue Sep 25, 2023 · 2 comments · Fixed by #27287
Closed
1 of 2 tasks

aws-stepfunctions-tasks: AthenaStartQueryExecution is missing ExecutionParameters #27286

nakedible-p opened this issue Sep 25, 2023 · 2 comments · Fixed by #27287
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@nakedible-p
Copy link
Contributor

Describe the feature

The StartQueryExecution call from Athena these days (Since July 2022) supports parameterized queries, which means passing in ExecutionParameters. These are also supported inside Step Functions as described in this documentation.

However, the CDK wrappering of Step Functions tasks for Athena does not support passing ExecutionParameters.

Use Case

I want to use a parameterized Athena query inside Step Functions.

Proposed Solution

Simply add ExecutionParameters, which is a string list, similarily to the existing QueryString and other parameters.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.97.0 (build d7cf3be)

Environment details (OS name and version, etc.)

irrelevant
@nakedible-p nakedible-p added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 25, 2023
@nakedible-p nakedible-p mentioned this issue Sep 25, 2023
Merged
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 25, 2023
@khushail
Copy link
Contributor

Hi @nakedible-p , thanks for the feature request and submitting a PR for adding ExecutionParameters.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Sep 25, 2023
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
@mergify mergify bot closed this as completed in #27287 Oct 11, 2023
mergify bot pushed a commit that referenced this issue Oct 11, 2023
@nakedible-p
feat(stepfunctions-tasks): add ExecutionParameters to `AthenaStartQ…
3fc86ca 
…ueryExecution` (#27287)

Add missing `ExecutionParameters` option to `AthenaStartQueryExecution` step.

Closes #27286.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions-tasks): add ExecutionParameters to AthenaStartQueryExecution nakedible-p/aws-cdk
2 participants
@nakedible-p @khushail