feat(stepfunctions-tasks): add `ExecutionParameters` to `AthenaStartQueryExecution` #27287

nakedible-p · 2023-09-25T20:59:13Z

Add missing ExecutionParameters option to AthenaStartQueryExecution step.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

nakedible-p · 2023-09-25T21:39:58Z

Need to manage to regenerate the integration test files and this should be good to go...

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Thanks for the contribution 💪
Left you some notes on a couple of minor fixes and a missing validation.

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

nakedible-p · 2023-09-29T23:16:12Z

@lpizzinidev Thank you for the review!

lpizzinidev

Thanks for applying the changes!
A couple of adjustments are needed on validation and some missing unit tests.

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

packages/aws-cdk-lib/aws-stepfunctions-tasks/test/athena/start-query-execution.test.ts

lpizzinidev

Thanks for the changes.
A couple of unit tests are needed to complete validation coverage.

lpizzinidev · 2023-10-04T14:12:45Z

packages/aws-cdk-lib/aws-stepfunctions-tasks/test/athena/start-query-execution.test.ts

@@ -224,4 +224,138 @@ describe('Start Query Execution', () => {
      }),
    });
  });
+
+  test('execution parameters succeeds', () => {


Missing test cases:

executionParameters: []

executionParameters: ['']

Add missing `ExecutionParameters` option to `AthenaStartQueryExecution` step.

…query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com> Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com> Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

…query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

vinayak-kukreja

This is great. Thank you for your contribution.

And also, thank you @lpizzinidev for reviewing the PR.

mergify · 2023-10-10T23:48:04Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2023-10-10T23:52:35Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

aws-cdk-automation · 2023-10-11T00:34:06Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 158c3b2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-10-11T02:09:12Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation requested a review from a team September 25, 2023 20:59

github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Sep 25, 2023

aws-cdk-automation previously requested changes Sep 25, 2023

View reviewed changes

nakedible-p changed the title ~~Add ExecutionParameters to AthenaStartQueryExecution~~ feat(stepfunctions-tasks): Add ExecutionParameters to AthenaStartQueryExecution Sep 25, 2023

nakedible-p force-pushed the patch-1 branch 2 times, most recently from a970f7c to 0d9d2e9 Compare September 25, 2023 21:22

nakedible-p force-pushed the patch-1 branch from 0d9d2e9 to 23b3667 Compare September 25, 2023 21:45

nakedible-p force-pushed the patch-1 branch from 9afb1f3 to 85633c3 Compare September 28, 2023 09:50

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 28, 2023

lpizzinidev suggested changes Sep 29, 2023

View reviewed changes

nakedible-p force-pushed the patch-1 branch from 85633c3 to f9aa98f Compare September 29, 2023 23:00

github-actions bot mentioned this pull request Oct 1, 2023

Monthly PRs metrics report - Sep 2023 #27368

Closed

lpizzinidev suggested changes Oct 2, 2023

View reviewed changes

nakedible-p force-pushed the patch-1 branch 3 times, most recently from fc9f3b1 to 3cc79b7 Compare October 4, 2023 13:04

lpizzinidev suggested changes Oct 4, 2023

View reviewed changes

TheRealAmazonKendra changed the title ~~feat(stepfunctions-tasks): Add ExecutionParameters to AthenaStartQueryExecution~~ feat(stepfunctions-tasks): add ExecutionParameters to AthenaStartQueryExecution Oct 4, 2023

github-actions bot added the effort/small Small work item – less than a day of effort label Oct 4, 2023

nakedible-p and others added 6 commits October 4, 2023 21:13

Add ExecutionParameters to AthenaStartQueryExecution

90727e4

Add missing `ExecutionParameters` option to `AthenaStartQueryExecution` step.

Add validation function for executionParameters

de78f8b

Add a bit more detail to documentation

ddd8057

Remove superfluous question mark

3738fe4

Add more testcases

0e49ff6

Add two more test cases for failures

4a24e3f

nakedible-p force-pushed the patch-1 branch from 6a7e75c to 4a24e3f Compare October 4, 2023 21:14

lpizzinidev reviewed Oct 5, 2023

View reviewed changes

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-…

81266aa

…query-execution.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 5, 2023

lpizzinidev approved these changes Oct 5, 2023

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 5, 2023

vinayak-kukreja previously approved these changes Oct 10, 2023

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2023

Merge branch 'main' into patch-1

158c3b2

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 11, 2023

vinayak-kukreja approved these changes Oct 11, 2023

View reviewed changes

mergify bot merged commit 3fc86ca into aws:main Oct 11, 2023
14 checks passed

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 11, 2023

nakedible-p deleted the patch-1 branch October 11, 2023 04:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(stepfunctions-tasks): add `ExecutionParameters` to `AthenaStartQueryExecution` #27287

feat(stepfunctions-tasks): add `ExecutionParameters` to `AthenaStartQueryExecution` #27287

nakedible-p commented Sep 25, 2023

aws-cdk-automation left a comment

nakedible-p commented Sep 25, 2023

lpizzinidev left a comment

nakedible-p commented Sep 29, 2023

lpizzinidev left a comment

lpizzinidev left a comment

lpizzinidev Oct 4, 2023 •

edited

vinayak-kukreja left a comment

mergify bot commented Oct 10, 2023

mergify bot commented Oct 10, 2023

aws-cdk-automation commented Oct 11, 2023

mergify bot commented Oct 11, 2023

feat(stepfunctions-tasks): add ExecutionParameters to AthenaStartQueryExecution #27287

feat(stepfunctions-tasks): add ExecutionParameters to AthenaStartQueryExecution #27287

Conversation

nakedible-p commented Sep 25, 2023

aws-cdk-automation left a comment

Choose a reason for hiding this comment

nakedible-p commented Sep 25, 2023

lpizzinidev left a comment

Choose a reason for hiding this comment

nakedible-p commented Sep 29, 2023

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev Oct 4, 2023 • edited

Choose a reason for hiding this comment

vinayak-kukreja left a comment

Choose a reason for hiding this comment

mergify bot commented Oct 10, 2023

mergify bot commented Oct 10, 2023

aws-cdk-automation commented Oct 11, 2023

AWS CodeBuild CI Report

mergify bot commented Oct 11, 2023

feat(stepfunctions-tasks): add `ExecutionParameters` to `AthenaStartQueryExecution` #27287

feat(stepfunctions-tasks): add `ExecutionParameters` to `AthenaStartQueryExecution` #27287

lpizzinidev Oct 4, 2023 •

edited