fix(apigateway): validation for path parts does not allow creation of resources beginning with dollar sign #27619
Conversation
…_-], an optional trailing '+'(module name)
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
bug
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Thanks 👍
Can you please update the title to describe the bug as per guidelines?
Suggestion: fix(apigateway): validation for path parts does not allow creation of resources with dollar sign.
aws-cdk-automation
added
pr/needs-maintainer-review
lawofcycles
changed the title
|
I misunderstood guideline that name of PR should be same to name of related issue. |
scanlonp
changed the title
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@scanlonp
I would appreciate it if you could let me know if further action is needed to resolve this issue. |
mergify
bot
dismissed
scanlonp’s stale review
Pull request has been modified.
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… resources beginning with dollar sign (#27619) This PR adjusts the validation rules for path parts in resources created using the APIGateway library to allow the use of dollar mark in pathParts, as requested in #27083. This enables the creation of resources with paths such as $test(from the reproduction steps in the related issue). An existing resource unit test ('url for a resource') has been updated to ensure that a dollar mark in a pathPart does not throw an error and properly reflects in the output of RestApi.urlForPath. The integration test integ.restapi has also been updated, wherein the appliances resource now has a path of $appliances:all instead of appliances:all. Closes #27083. #### All Submissions: - [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) #### Adding new Unconventional Dependencies: - [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) #### New Features - [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? - [x] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
This PR adjusts the validation rules for path parts in resources created using the APIGateway library to allow the use of dollar mark in pathParts, as requested in #27083. This enables the creation of resources with paths such as $test(from the reproduction steps in the related issue).
An existing resource unit test ('url for a resource') has been updated to ensure that a dollar mark in a pathPart does not throw an error and properly reflects in the output of RestApi.urlForPath. The integration test integ.restapi has also been updated, wherein the appliances resource now has a path of $appliances:all instead of appliances:all.
Closes #27083.
All Submissions:
Adding new Unconventional Dependencies:
New Features
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license