feat(dynamodb): add tagging support to TableV2 #27649
Conversation
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
effort/medium
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mikevec23
changed the title
mikevec23
force-pushed
the
tablev2_tagging
branch
from
be9deed
to
97adde9
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mikevec23
force-pushed
the
tablev2_tagging
branch
from
97adde9
to
cddcacc
Compare
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mikevec23
force-pushed
the
tablev2_tagging
branch
2 times, most recently
from
f3e181d
to
ffb4679
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mikevec23
force-pushed
the
tablev2_tagging
branch
from
ffb4679
to
317e792
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
There was a problem hiding this comment.
@mikevec23 I think this looks great! My only concern is with using CfnTag vs. Tags.of(...).add(...). I recognize that the underlying L1 doesn't implement the ITaggable interface which would prevent the use of Tags, but I'd like to get another opinion on whether this is the right approach or if we should find a way to do this using Tags. I'll get an update for you soon.
colifran
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This change adds the ability to tag GlobalTable replicas created using the TableV2 construct. The top level "tags" will apply tags to the primary table while tags for each replica can be specified in the respective replica definition. Closes #27146. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This change adds the ability to tag GlobalTable replicas created using the TableV2 construct. The top level "tags" will apply tags to the primary table while tags for each replica can be specified in the respective replica definition.
Closes #27146.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license