Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline-actions): default branch for CodeCommit is master (under feature flag) #27753

Merged

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Oct 30, 2023

Closes #27710.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Oct 30, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 30, 2023 12:03
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Oct 30, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@daschaa
Copy link
Contributor Author

daschaa commented Oct 30, 2023

Exemption Request: I ran the integration tests and the snapshots have been changed. So I think a new integration test is not needed.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 30, 2023
@mikewrighton mikewrighton self-assigned this Oct 30, 2023
@daschaa daschaa marked this pull request as ready for review October 30, 2023 18:52
@kylelaker
Copy link
Contributor

I am not sure but wouldn't this probably need a feature flag? Since a user may have deployed when the default was master and built their stack when that was the expectation (according to https://docs.aws.amazon.com/codecommit/latest/userguide/history.html, any stacks built prior to March 2021 or repositories created via the console/API prior to Jan 2021), I think updating this to main would require them to make a code change in order to continue having a functioning stack.

@daschaa
Copy link
Contributor Author

daschaa commented Oct 31, 2023

@kylelaker Thanks for the feedback. :) I think you are right - it would make sense to introduce a feature flag here. I'll try to implement this.
And if one of the maintainers says that it doesn't need a feature flag after all, I can revert the changes.

@daschaa daschaa changed the title fix(codepipeline-actions): The default branch for CodeCommit is master fix(codepipeline-actions): default branch for CodeCommit is master (under feature flag) Oct 31, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 31, 2023 09:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mikewrighton
Copy link
Contributor

Will approve once the build is fixed.

Copy link
Contributor

mergify bot commented Nov 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 1, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f0344bb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 93c6a9a into aws:main Nov 1, 2023
12 checks passed
Copy link
Contributor

mergify bot commented Nov 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codepipelineActions.CodeCommitSourceAction: Default branch is 'Master'
4 participants