Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(stepfunctions-tasks): EMR createCluster command support OnDemandSpecification #27761

Closed
2 tasks
rsmayda opened this issue Oct 30, 2023 · 2 comments · Fixed by #27791
Closed
2 tasks

(stepfunctions-tasks): EMR createCluster command support OnDemandSpecification #27761

rsmayda opened this issue Oct 30, 2023 · 2 comments · Fixed by #27791
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@rsmayda
Copy link

rsmayda commented Oct 30, 2023 •
edited

Describe the feature

The current InstanceFleetProvisioningSpecificationsProperty only supports spot specification, whereas the EMR InstanceFleetProvisioningSpecifications supports OnDemandSpecification. I would like the functionality to add OnDemandSpecifications for our usecase.

Use Case

Functional parity with options available in EMR and for our internal use where we need to specify AllocationStrategy under OnDemandSpecifications.

Proposed Solution

Add OnDemandProvisioningSpecificationProperty type with allocationStrategyProperty. Add a field called onDemandSpecification to InstanceFleetProvisioningSpecificationsProperty here

Finally modify this function InstanceFleetProvisioningSpecificationsPropertyToJson to emit the relevant parameters for ondemand specification.

Other Information

Duplicate of old stale issue: #12501

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.100

Environment details (OS name and version, etc.)

macOS: 13.5.2
@rsmayda rsmayda added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2023
@rsmayda rsmayda mentioned this issue Oct 30, 2023
Closed
2 tasks
@rsmayda
Copy link
Author

rsmayda commented Oct 30, 2023

To work around I just created my own extended TaskStateBase and that worked. This is frail, would love 1st party support

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 31, 2023
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@go-to-k go-to-k mentioned this issue Nov 1, 2023
Merged
@mergify mergify bot closed this as completed in #27791 Dec 21, 2023
mergify bot pushed a commit that referenced this issue Dec 21, 2023
@go-to-k
feat(stepfunctions-tasks): EMR createCluster command support OnDemand…
73a5e74 
…Specification (#27791)

This PR supports OnDemandSpecification in instance fleets for EMR createCluster.

Closes #27761.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
@go-to-k @paulhcsun
feat(stepfunctions-tasks): EMR createCluster command support OnDemand…
ed4589f 
…Specification (aws#27791)

This PR supports OnDemandSpecification in instance fleets for EMR createCluster.

Closes aws#27761.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions-tasks): EMR createCluster command support OnDemandSpecification go-to-k/aws-cdk
2 participants
@pahud @rsmayda