Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-bucket-deployment): update logging statement to ensure one-line logging #28057

Merged
merged 13 commits into from
Nov 20, 2023
Merged

fix(s3-bucket-deployment): update logging statement to ensure one-line logging #28057

merged 13 commits into from
Nov 20, 2023

Conversation

martinschaef
Copy link
Contributor

@martinschaef martinschaef commented Nov 17, 2023

Our current logging statement for s3 bucket deployments is inconsistent. This PR updates the logging statement to ensure consistent one-line logging.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 17, 2023 21:03
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vinayak-kukreja vinayak-kukreja changed the title fix(aws-s3): updated logging format fix(s3-bucket-deployment): updated logging format Nov 17, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Nov 17, 2023
@vinayak-kukreja vinayak-kukreja added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 17, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 17, 2023 21:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@vinayak-kukreja vinayak-kukreja changed the title fix(s3-bucket-deployment): updated logging format fix(s3-bucket-deployment): logging statement is inconsistent Nov 17, 2023
…lk-deploy.js

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@mergify mergify bot dismissed vinayak-kukreja’s stale review November 17, 2023 21:45

Pull request has been modified.

vinayak-kukreja and others added 7 commits November 17, 2023 13:55
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2023
@colifran colifran changed the title fix(s3-bucket-deployment): logging statement is inconsistent fix(s3-bucket-deployment): update logging statement to ensure one-line logging Nov 20, 2023
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label Nov 20, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2023
@vinayak-kukreja vinayak-kukreja removed the pr/do-not-merge This PR should not be merged at this time. label Nov 20, 2023
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: da74e2b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b01e17d into aws:main Nov 20, 2023
9 checks passed
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants