Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efs: support for FileSystemProtection property for file system #28912

Closed
1 of 2 tasks
badmintoncryer opened this issue Jan 29, 2024 · 2 comments · Fixed by #28913
Closed
1 of 2 tasks

efs: support for FileSystemProtection property for file system #28912

badmintoncryer opened this issue Jan 29, 2024 · 2 comments · Fixed by #28913
Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

There is FileSystemProtection.ReplicationOverwriteProtection parameter for replication configuration in the EFS file system. CloudFormation supports this setting, so I want to enable its configuration through the L2 constructor.

Use Case

When creating a replication destination filesystem, it is necessary to set the ReplicationOverwriteProtection configuration to DISABLED, but this cannot be executed from the L2 construct.

Proposed Solution

Since this parameter can only take two values, 'ENABLED' or 'DISABLED', I plan to convert a boolean type argument into the appropriate string within the L2 construct.

new FileSystem(stack, 'EfsFileSystem', {
    vpc,
    replicationOverwriteProtection: false, // 'DISABLED'
  });

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.123.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2024
@github-actions github-actions bot added the @aws-cdk/aws-efs Related to Amazon Elastic File System label Jan 29, 2024
@badmintoncryer badmintoncryer mentioned this issue Jan 29, 2024
Merged
@pahud
Copy link
Contributor

pahud commented Jan 29, 2024

Yes! We should support that. Thank you for your PR.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2024
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
@mergify mergify bot closed this as completed in #28913 Feb 7, 2024
mergify bot pushed a commit that referenced this issue Feb 7, 2024
@badmintoncryer
feat(efs): create read-only file system for use as a destination of r…
832f70c 
…eplication (#28913)

In this PR, I have added the `replicationOverwriteProtection` argument to the L2 construct. This enables the creation of a filesystem that can be used as a destination for replication.

```ts
const fileSystem = new efs.FileSystem(this, 'MyEfsFileSystem', {
  vpc: new ec2.Vpc(this, 'VPC'),
  replicationOverwriteProtection: true, // Set to false if you want to create a read-only file system for use as a replication destination
});
```

Closes #28912.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TheRealAmazonKendra pushed a commit that referenced this issue Feb 9, 2024
@badmintoncryer @TheRealAmazonKendra
feat(efs): create read-only file system for use as a destination of r…
e65d1dd 
…eplication (#28913)

In this PR, I have added the `replicationOverwriteProtection` argument to the L2 construct. This enables the creation of a filesystem that can be used as a destination for replication.

```ts
const fileSystem = new efs.FileSystem(this, 'MyEfsFileSystem', {
  vpc: new ec2.Vpc(this, 'VPC'),
  replicationOverwriteProtection: true, // Set to false if you want to create a read-only file system for use as a replication destination
});
```

Closes #28912.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @badmintoncryer