Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-codepipeline: add GitPullRequestFilter for pipeline trigger #29126

Closed
1 of 2 tasks
go-to-k opened this issue Feb 16, 2024 · 5 comments · Fixed by #29128
Closed
1 of 2 tasks

aws-codepipeline: add GitPullRequestFilter for pipeline trigger #29126

go-to-k opened this issue Feb 16, 2024 · 5 comments · Fixed by #29128
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@go-to-k
Copy link
Contributor

go-to-k commented Feb 16, 2024

Describe the feature

Currently, CDK only supports GitPushFilter. However, CloudFormation already supports GitPullRequestFilter, which can also be supported by CDK.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitpullrequestfilter.html

Use Case

We would be good to trigger pipelines by git pull request filters.

Proposed Solution

Add gitPullRequestFilter parameter with new interface into GitConfiguration interface.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.128.0

Environment details (OS name and version, etc.)

MacOS 13.0
@go-to-k go-to-k added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Feb 16, 2024
@go-to-k
Copy link
Contributor Author

go-to-k commented Feb 16, 2024

I will take this issue.

@go-to-k go-to-k mentioned this issue Feb 16, 2024
Merged
1 task
@pahud
Copy link
Contributor

pahud commented Feb 16, 2024

Awesome! Thanks!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2024
@github-actions github-actions bot mentioned this issue Mar 1, 2024
Closed
@jochemd
Copy link

jochemd commented Apr 17, 2024

We are very interested in getting this issue resolved. The PR #29128 appears to solve what we would want. Is there anything we can do to help this along?

@go-to-k
Copy link
Contributor Author

go-to-k commented Apr 17, 2024

Thanks, @jochemd

The PR is awaiting review by the maintainer. Please wait a little longer; a thumbs up reaction to the issue may raise the priority of the review.

@mergify mergify bot closed this as completed in #29128 May 13, 2024
mergify bot pushed a commit that referenced this issue May 13, 2024
@go-to-k
feat(codepipeline): GitPullRequestFilter for pipeline trigger (#29128)
5ce1b64 
### Issue # (if applicable)

Closes #29126.

Related PR: #29127
Perhaps if one merges, the other will cause a conflict.

### Reason for this change

We would be good to trigger pipelines by git pull request filters.

- CFn and API docs
  - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitconfiguration.html
  - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-gitpullrequestfilter.html
  - https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_GitPullRequestFilter.html

### Description of changes

Add `gitPullRequestFilter` parameter with new interface into `GitConfiguration` interface.

### Description of how you validated changes

Both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codepipeline): GitPullRequestFilter for pipeline trigger go-to-k/aws-cdk
3 participants
@pahud @jochemd @go-to-k