-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(network-load-balanced-fargate-service): (Add support for creating load balancer with IPv6 support) #29614
Closed
2 tasks
vishnu0179 opened this issue
Mar 26, 2024
· 3 comments
· Fixed by #30069 · 4 remaining pull requests
Closed
2 tasks
(network-load-balanced-fargate-service): (Add support for creating load balancer with IPv6 support) #29614
vishnu0179 opened this issue
Mar 26, 2024
· 3 comments
· Fixed by #30069 · 4 remaining pull requests
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
vishnu0179
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 26, 2024
github-actions
bot
added
the
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
label
Mar 26, 2024
vishnu0179
changed the title
(network-load-balanced-fargate-service): (Add support for creating v6 load balancer)
(network-load-balanced-fargate-service): (Add support for creating load balancer with IPv6 support)
Mar 26, 2024
tim-finnigan
added
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 26, 2024
Thanks for the feature request. |
tim-finnigan
added
p2
effort/medium
Medium work item – several days of effort
and removed
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
labels
Mar 26, 2024
This was referenced Apr 1, 2024
1 task
mergify bot
pushed a commit
that referenced
this issue
May 17, 2024
### Issue # (if applicable) Closes #29614. ### Reason for this change Dualstack NLB is not supported in `NetworkLoadBalancedServiceBase`. ### Description of changes - Add `ipAddressType` to `NetworkLoadBalancedServiceBaseProps`. - default value is `IpAddressType.Ipv4` ### Description of how you validated changes Add both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
atanaspam
pushed a commit
to atanaspam/aws-cdk
that referenced
this issue
Jun 3, 2024
### Issue # (if applicable) Closes aws#29614. ### Reason for this change Dualstack NLB is not supported in `NetworkLoadBalancedServiceBase`. ### Description of changes - Add `ipAddressType` to `NetworkLoadBalancedServiceBaseProps`. - default value is `IpAddressType.Ipv4` ### Description of how you validated changes Add both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
Today, if i want to use
network-load-balanced-fargate-service
construct for creating a fargate service with network loadbalancer attached, we dont have an option to enable IPv6 on Network Loadbalancer. There is no corresponding prop available for the users of this construct to opt for IPv6 NLB.https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ecs-patterns/lib/base/network-load-balanced-service-base.ts#L34
We want an prop
ipAddressType
to control to enable IPv6 address on our load balancer.Use Case
Our service has a public network load balancer and our client recommends enabling IPv6 for the calling endpoint.
Proposed Solution
Adding an prop
ipAddressType
in network-load-balanced-service-base.ts so that clients of this can control enabling of loadbalancer IPv6.Default would be IpAddressType.IPV4 for backward compatibilty.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticloadbalancingv2.NetworkLoadBalancer.html
Other Information
No response
Acknowledgements
CDK version used
2.14.0
Environment details (OS name and version, etc.)
NA
The text was updated successfully, but these errors were encountered: