Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws_ecs.FargateTaskDefinition): (support for pidMode) #29619

Closed
ssplatt opened this issue Mar 26, 2024 · 4 comments · Fixed by #29670 or rwlxxvii/containers#124 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Closed

(aws_ecs.FargateTaskDefinition): (support for pidMode) #29619

ssplatt opened this issue Mar 26, 2024 · 4 comments · Fixed by #29670 or rwlxxvii/containers#124 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@ssplatt
Copy link
Contributor

ssplatt commented Mar 26, 2024

Describe the bug

ecs.TaskDefinition supports pidMode. ecs.FargateTaskDefinition should as well.

Expected Behavior

supports pidMode

Current Behavior

does not support pidMode

Reproduction Steps

try to use pidMode as an arg

Possible Solution

add support for pidMode

Additional Information/Context

No response

CDK CLI Version

2.133.0

Framework Version

No response

Node.js Version

18

OS

mac os

Language

TypeScript

Language Version

No response

Other information

No response
@ssplatt ssplatt added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Mar 26, 2024
@ssplatt
Copy link
Contributor Author

ssplatt commented Mar 26, 2024 •
edited

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.FargateTaskDefinition.html (no pidMode)
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.TaskDefinition.html#construct-props (has pidMode)
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-taskdefinition.html#cfn-ecs-taskdefinition-pidmode cloudformation docs

@tim-finnigan tim-finnigan self-assigned this Mar 28, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 28, 2024
@tim-finnigan
Copy link

Thanks for reporting this issue, it looks like pidMode should be supported.

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 28, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 28, 2024
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@lpizzinidev lpizzinidev mentioned this issue Apr 1, 2024
Merged
3 tasks
This was referenced Apr 1, 2024
Closed
Closed
aaythapa added a commit to lpizzinidev/aws-cdk that referenced this issue Apr 22, 2024
@aaythapa
Merge branch 'main' into awsgh-29619
1fc0d23
@mergify mergify bot closed this as completed in #29670 Apr 22, 2024
mergify bot pushed a commit that referenced this issue Apr 22, 2024
@lpizzinidev
feat(ecs): support pidMode for FargateTaskDefinition (#29670)
ed75b16 
### Issue # (if applicable)

Closes #29619.

### Reason for this change

Support [`pidMode`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-taskdefinition.html#cfn-ecs-taskdefinition-pidmode) for `FargateTaskDefinition`.

### Description of changes

Added support for the `pidMode` property along with the necessary validation, documentation, and test coverage.

### Description of how you validated changes

- [x] Unit tests
- [x] Integration tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@shuluster
Copy link

Resource handler returned message: "Invalid request provided: Create TaskDefinition: Tasks using the Fargate launch type do not support pidMode 'host'. The supported value for pidMode is 'task'. (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Request ID: a75d06a4-dc4c-4209-b464-d33e0ba66f0a; Proxy: null)" (RequestToken: 20902d22-1d4f-1a6e-2db1-ddf7b63bb7b1, HandlerErrorCode: InvalidRequest)

This was referenced May 23, 2024
Open
Open
@rwlxxvii rwlxxvii mentioned this issue May 27, 2024
Merged
@NOUIY NOUIY mentioned this issue May 30, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this issue Jun 13, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this issue Jun 20, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 20, 2024
Open
@snyk-io snyk-io bot mentioned this issue Jun 21, 2024
Open
@rwlxxvii rwlxxvii mentioned this issue Jun 22, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Milestone
No milestone
3 participants
@shuluster @ssplatt @tim-finnigan