-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sns: KMS key is not deleted in integ.sns.ts #29663
Labels
@aws-cdk/aws-sns
Related to Amazon Simple Notification Service
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Comments
jun1-t
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 31, 2024
github-actions
bot
added
the
@aws-cdk/aws-sns
Related to Amazon Simple Notification Service
label
Mar 31, 2024
1 task
This was referenced Apr 1, 2024
tim-finnigan
added
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 1, 2024
Thanks for report this issue and creating the PR. |
tim-finnigan
added
p2
effort/small
Small work item – less than a day of effort
and removed
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
labels
Apr 1, 2024
mergify bot
pushed a commit
that referenced
this issue
Apr 1, 2024
### Issue # (if applicable) Closes #29663 ### Reason for this change kms key created within integ test remains after integ test. ### Description of changes Added "pendingWindow" and "removalPolicy" to kms resource. ```ts const key = new Key(this, 'CustomKey', { pendingWindow: Duration.days(7), removalPolicy: RemovalPolicy.DESTROY, }); ``` ### Description of how you validated changes I confirmed with integ test that it works as expected. ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-sns
Related to Amazon Simple Notification Service
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Describe the bug
KMS key is created in integ test(integ.sns.ts), but KMS key remains after integ test.
Because RemovalPolicy.DESTROY is not set.
Expected Behavior
KMS key created within integ test should be deleted.
Current Behavior
KMS key created within integ test remains after integ test.
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.134.0
Framework Version
No response
Node.js Version
v18.17.1
OS
Linux/UNIX
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: