Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ses): enable setting vdmOptions in ConfigurationSet #30041

Closed
1 of 2 tasks
mazyu36 opened this issue May 2, 2024 · 3 comments · Fixed by #30051 · May be fixed by NOUIY/aws-solutions-constructs#108 or NOUIY/aws-solutions-constructs#109
Closed
1 of 2 tasks

(ses): enable setting vdmOptions in ConfigurationSet #30041

mazyu36 opened this issue May 2, 2024 · 3 comments · Fixed by #30051 · May be fixed by NOUIY/aws-solutions-constructs#108 or NOUIY/aws-solutions-constructs#109
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 2, 2024

Describe the feature

CfnConfigurationSet supported vdmOptions, but ConfigurationSet does not support vdmOptions.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-ses-configurationset.html#cfn-ses-configurationset-vdmoptions

Use Case

It's useful when you want to setting vdmOptions to the configuration set.

Proposed Solution

Add vdmOptions to ConfigurationSet.

    new ConfigurationSet(stack, 'ConfigurationSet', {
      customTrackingRedirectDomain: 'track.cdk.dev',
      suppressionReasons: SuppressionReasons.COMPLAINTS_ONLY,
      tlsPolicy: ConfigurationSetTlsPolicy.REQUIRE,
      dedicatedIpPool: new DedicatedIpPool(stack, 'Pool'),
      vdmOptions: { // Add
        engagementMetrics: true, // Add
        optimizedSharedDelivery: true, // Add
      }
    });

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.139.1

Environment details (OS name and version, etc.)

MacOS
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 2, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ses Related to Amazon Simple Email Service label May 2, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 2, 2024
@khushail
Copy link
Contributor

khushail commented May 2, 2024

Thanks @mazyu36 for requesting this. I can see Cloudformation supports this and provides as in L1 construct. Please feel free to submit a PR.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 2, 2024
@mazyu36 mazyu36 mentioned this issue May 3, 2024
Merged
1 task
This was referenced May 6, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
@mergify mergify bot closed this as completed in #30051 Jun 18, 2024
@mergify mergify bot closed this as completed in 49a98ac Jun 18, 2024
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

sarangarav pushed a commit to sarangarav/aws-cdk that referenced this issue Jun 21, 2024
@mazyu36
feat(ses): allow VDM settings at the configuration set level (aws#30051)
5d1fb75 
### Issue # (if applicable)

Closes aws#30041 .

### Reason for this change
As described in the issue.



### Description of changes
To allow VDM settings at the configuration set level, `vdmOptions` property has been added to the `ConfigurationSet` Construct.

```ts
new ses.ConfigurationSet(this, 'ConfigurationSetWithVdmOptions', {
  vdmOptions: { // Add
    engagementMetrics: true,
    optimizedSharedDelivery: true,
  },
});
```



### Description of how you validated changes
I implemented unit tests and integration tests for the three cases.

1. Configuration set with both engagement metrics and optimized shared delivery enabled.
2. Configuration set with only engagement metrics enabled and optimized shared delivery not configured.
3. Configuration set with only optimized shared delivery enabled and engagement metrics not configured.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 added a commit to mazyu36/aws-cdk that referenced this issue Jun 22, 2024
@mazyu36
feat(ses): allow VDM settings at the configuration set level (aws#30051)
04073da 
### Issue # (if applicable)

Closes aws#30041 .

### Reason for this change
As described in the issue.



### Description of changes
To allow VDM settings at the configuration set level, `vdmOptions` property has been added to the `ConfigurationSet` Construct.

```ts
new ses.ConfigurationSet(this, 'ConfigurationSetWithVdmOptions', {
  vdmOptions: { // Add
    engagementMetrics: true,
    optimizedSharedDelivery: true,
  },
});
```



### Description of how you validated changes
I implemented unit tests and integration tests for the three cases.

1. Configuration set with both engagement metrics and optimized shared delivery enabled.
2. Configuration set with only engagement metrics enabled and optimized shared delivery not configured.
3. Configuration set with only optimized shared delivery enabled and engagement metrics not configured.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jul 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
3 participants
@pahud @mazyu36 @khushail