Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsx: enable automatic backup settings for Lustre file system #30340

Closed
1 of 2 tasks
mazyu36 opened this issue May 26, 2024 · 3 comments · Fixed by #30343
Closed
1 of 2 tasks

fsx: enable automatic backup settings for Lustre file system #30340

mazyu36 opened this issue May 26, 2024 · 3 comments · Fixed by #30343
Labels
@aws-cdk/aws-fsx Related to Amazon FSx effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3 pr/work-in-progress This PR is a draft and needs further work.

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 26, 2024 •
edited
Loading

Describe the feature

In the L1 construct, automatic backup settings can be used for the Lustre file system. However, the LustreFileSystem class does not support automatic backups.

Use Case

To enable automatic backup settings

Proposed Solution

Add the following properties from the L1 LustreConfigurationProperty to the L2 LustreConfiguration:

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0

Environment details (OS name and version, etc.)

All
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-fsx Related to Amazon FSx label May 26, 2024
@mazyu36 mazyu36 mentioned this issue May 26, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue May 27, 2024
Closed
@ashishdhingra ashishdhingra self-assigned this May 28, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 28, 2024
@ashishdhingra
Copy link
Contributor

ashishdhingra commented May 28, 2024 •
edited
Loading

@mazyu36 Thanks for the PR. Looks like property driveCacheType is also missing from L2 LustreConfiguration. Could you please review?

Thanks,
Ashish

@ashishdhingra ashishdhingra added p2 pr/work-in-progress This PR is a draft and needs further work. effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 28, 2024
@ashishdhingra ashishdhingra removed their assignment May 28, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented May 28, 2024 •
edited
Loading

@ashishdhingra
Thank you for your comment. You're correct that driveCacheType does not exist either. However, this item is not related to backups and is related to the storage type.

This parameter is required when storage type is HDD.

Therefore, I think it would be preferable to address it either in #30207, which is adding the storage type, or in a separate PR.

Please let me know if you have any other thoughts or suggestions.​​​​​​​​​​​​​​​​

@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
@mergify mergify bot closed this as completed in #30343 Jun 21, 2024
mergify bot pushed a commit that referenced this issue Jun 21, 2024
@mazyu36
feat(fsx): add properties to enable automatic backups for Lustre file…
3b95777 
… system (#30343)

### Issue # (if applicable)

Closes  #30340.

### Reason for this change
Current LustreFileSystem class does not support automatic backups.


### Description of changes
Add properties equivalent to those of the L1 construct to the L2 construct.

* [automaticBackupRetentionDays](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws%5C_fsx.CfnFileSystem.LustreConfigurationProperty.html#automaticbackupretentiondays)
* [copyTagsToBackups](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws%5C_fsx.CfnFileSystem.LustreConfigurationProperty.html#copytagstobackups)
* [dailyAutomaticBackupStartTime](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws%5C_fsx.CfnFileSystem.LustreConfigurationProperty.html#dailyautomaticbackupstarttime)

Segregated the `dailyAutomaticBackupStartTime` as a class to enable its usage in another file system's L2 construct (for example, Ontap) in the future.



### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-fsx Related to Amazon FSx effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3 pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fsx): add properties to enable automatic backups for Lustre file system mazyu36/aws-cdk
3 participants
@pahud @mazyu36 @ashishdhingra