Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codedeploy: zonal configuration for the EC2/on-premises deploy configuration #30430

Closed
1 of 2 tasks
badmintoncryer opened this issue Jun 2, 2024 · 4 comments · Fixed by #30429
Closed
1 of 2 tasks

codedeploy: zonal configuration for the EC2/on-premises deploy configuration #30430

badmintoncryer opened this issue Jun 2, 2024 · 4 comments · Fixed by #30429
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Configure zonal configuration for the EC2/on-premises deploy configuration.

Use Case

ServerDeploymentConfig class does not support for configuring zonal configuration.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.141.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 2, 2024
@github-actions github-actions bot added the @aws-cdk/aws-codedeploy Related to AWS CodeDeploy label Jun 2, 2024
@badmintoncryer badmintoncryer mentioned this issue Jun 2, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Jun 3, 2024
Closed
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 3, 2024
@khushail khushail self-assigned this Jun 3, 2024
@khushail
Copy link
Contributor

khushail commented Jun 7, 2024

thanks @badmintoncryer for submitting the PR.

@khushail khushail added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jun 7, 2024
@khushail khushail removed their assignment Jun 7, 2024
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
@mergify mergify bot closed this as completed in #30429 Jul 8, 2024
@mergify mergify bot closed this as completed in da0dc57 Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

GavinZZ pushed a commit that referenced this issue Jul 10, 2024
@badmintoncryer @GavinZZ
feat(codedeploy): zonal configuration for ServerDeploymentConfig (#…
237bf9d 
…30429)

### Issue # (if applicable)

Closes #30430

### Reason for this change

`ServerDeploymentConfig` does not support for configuring the [zonal configuration](https://docs.aws.amazon.com/codedeploy/latest/userguide/deployment-configurations-create.html#zonal-config).

### Description of changes

- define `ZonalConfig` interface
- define `MinimumHealthyHostsPerZone` class
- add `zonalConfig` property to the `BaseDeploymentConfigProps`

### Description of how you validated changes

Add both unit and integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codedeploy): zonal configuration for ServerDeploymentConfig badmintoncryer/aws-cdk
3 participants
@aws-cdk-automation @badmintoncryer @khushail