fix(apigateway): invalid schema generated due to un-mapped ref
#3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a `ref` (which in JSON Schema really is `$ref$`) for the type of some object property, the `$ref` replacement did not happen because the arbitrary property names were not white-listed for transformation.
|
@RomainMuller what's up with this? |
|
@RomainMuller can you please update from master? |
eladb
changed the title
refref
|
@RomainMuller can you follow up on this? |
|
@eladb - this is now in a mergeable state! |
eladb
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
ref(which in JSON Schema really is$ref) for the typeof some object property, the
$refreplacement did not happen becausethe arbitrary property names were not white-listed for transformation.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license