Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): support imported roles for integrations #3369

Merged
merged 7 commits into from
Aug 13, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jul 21, 2019

Change type of IntegrationOptions.credentialsRole to IRole to enable
using an imported role.

Fixes #2860


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Change type of `IntegrationOptions.credentialsRole` to `IRole` to enable
using an imported role.

Fixes #2860
@eladb eladb requested a review from a team as a code owner July 21, 2019 11:14
shivlaks
shivlaks previously approved these changes Jul 21, 2019
@NGL321 NGL321 added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Aug 1, 2019
@eladb eladb changed the title feat(apigateway): support imported roles for intgrations feat(apigateway): support imported roles for intggrations Aug 5, 2019
@eladb eladb changed the title feat(apigateway): support imported roles for intggrations feat(apigateway): support imported roles for integrations Aug 13, 2019
Elad Ben-Israel added 2 commits August 13, 2019 11:47
Since this is read only by `Method`.

This is technically a breaking change, but props is not part of the expected API.
@mergify mergify bot merged commit 15df3c7 into master Aug 13, 2019
@eladb eladb deleted the benisrae/apigateway-import-role branch August 13, 2019 19:01
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting Execution Role ARN in Lambda Integration Request - API Gateway
4 participants