-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigateway): support imported roles for integrations #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change type of `IntegrationOptions.credentialsRole` to `IRole` to enable using an imported role. Fixes #2860
shivlaks
previously approved these changes
Jul 21, 2019
eladb
changed the title
feat(apigateway): support imported roles for intgrations
feat(apigateway): support imported roles for intggrations
Aug 5, 2019
eladb
changed the title
feat(apigateway): support imported roles for intggrations
feat(apigateway): support imported roles for integrations
Aug 13, 2019
Since this is read only by `Method`. This is technically a breaking change, but props is not part of the expected API.
skinny85
approved these changes
Aug 13, 2019
5 tasks
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-apigateway
Related to Amazon API Gateway
contribution/core
This is a PR that came from AWS.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type of
IntegrationOptions.credentialsRole
toIRole
to enableusing an imported role.
Fixes #2860
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license