Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-region capabilities for non-CloudFormation CodePipeline Actions #3387

Closed
skinny85 opened this issue Jul 22, 2019 · 0 comments · Fixed by #3777
Closed

Cross-region capabilities for non-CloudFormation CodePipeline Actions #3387

skinny85 opened this issue Jul 22, 2019 · 0 comments · Fixed by #3777
Assignees
@skinny85
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/large Large work item – several weeks of effort

Comments

@skinny85
Copy link
Contributor

Currently, only CloudFormation Actions can be made cross-region.

We need to add logic to the CodePipeline construct, similar to the logic for the region property we have there currently, to handle the case when the resource passed to it is housed in a different region. When that happens, we need to set the replication Bucket correctly in the artifactStores property of the Pipeline, generating the Bucket if necessary.
@skinny85 skinny85 added @aws-cdk/aws-codepipeline Related to AWS CodePipeline gap labels Jul 22, 2019
@skinny85 skinny85 mentioned this issue Jul 23, 2019
Closed
@fulghum fulghum added the effort/large Large work item – several weeks of effort label Jul 29, 2019
@skinny85 skinny85 mentioned this issue Aug 24, 2019
Merged
skinny85 added a commit that referenced this issue Sep 18, 2019
@skinny85
feat(codepipeline): handle non-CFN cross-region actions (#3777)
b8b4c4d 
Adds support for actions other than the CloudFormation ones to be cross-region.

It works similarly to the cross-account support: passing a resource from a different region into a CodePipeline action makes the action implicitly cross-region.

Closes #3387
eladb pushed a commit that referenced this issue Sep 23, 2019
@skinny85
feat(codepipeline): handle non-CFN cross-region actions (#3777)
e02c242 
Adds support for actions other than the CloudFormation ones to be cross-region.

It works similarly to the cross-account support: passing a resource from a different region into a CodePipeline action makes the action implicitly cross-region.

Closes #3387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/large Large work item – several weeks of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codepipeline): handle non-CFN cross-region actions skinny85/aws-cdk
2 participants
@fulghum @skinny85