feat(core): allow multiple transforms on ITemplateOptions #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates the `templateOptions.transform` field and introduces a new `templateOptions.transforms` field. When both are specified, the deprecated field's value is prepended to the new field value, preserving original behavior. Fixes #3366
eladb
approved these changes
Jul 23, 2019
eladb
reviewed
Jul 23, 2019
jogold
added a commit
to jogold/aws-cdk
that referenced
this pull request
Nov 25, 2019
Was not included in aws#3395 and leads, among other things, to deprecation warnings when creating a new RDS Database Instance which uses a serverless application for the password rotation.
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2019
* chore: remove usage of deprecated `transform` Was not included in #3395 and leads, among other things, to deprecation warnings when creating a new RDS Database Instance which uses a serverless application for the password rotation. * addTransform * add test * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the
templateOptions.transformfield and introduces anew
templateOptions.transformsfield. When both are specified, thedeprecated field's value is prepended to the new field value, preserving
original behavior.
Fixes #3366
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license