fix(region-info): IAM service principal for China regions #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnusunny
changed the title
|
@RomainMuller Hello, I'm not able to see the CodeBuild details. Can you help to see what failed? |
RomainMuller
reviewed
Aug 7, 2019
There was a problem hiding this comment.
The CodeBuild job fails on an API breaking change:
@aws-cdk/aws-events... CHANGES.
Original assembly: @aws-cdk/aws-events@1.3.0
Updated assembly: @aws-cdk/aws-events@1.2.0
API elements with incompatible changes:
err - PROP @aws-cdk/aws-events.RuleTargetConfig.targetResource: has been removed [removed:@aws-cdk/aws-events.RuleTargetConfig.targetResource]
I don't reckon this is caused by your work.
packages/@aws-cdk/region-info/build-tools/generate-static-data.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/region-info/build-tools/generate-static-data.ts
Outdated
Show resolved
Hide resolved
…s' into region-info-fix-for-china-regions # Conflicts: # packages/@aws-cdk/region-info/package-lock.json
RomainMuller
previously approved these changes
Aug 13, 2019
|
@RomainMuller @eladb @rix0rrr I merged the latest master and updated the new code. The tests are green. Can you please help to review and accept before more changes are merge into master? Thanks in advance. |
RomainMuller
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2198
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license