Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): allow reusing lambda integration for multiple apis #3532

Merged
merged 7 commits into from
Aug 13, 2019
Merged

fix(apigateway): allow reusing lambda integration for multiple apis #3532

merged 7 commits into from
Aug 13, 2019

Conversation

hoegertn
Copy link
Contributor

@hoegertn hoegertn commented Aug 3, 2019

When using the same Lambda(-Integration) for the same path in multiple RestApi instances, this fails due to duplicate resources. By adding the restApiId to the permission this is fixed.

Fixes #3609


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@hoegertn hoegertn changed the title fix: allow multiple uses of Lambdas inAPI GW fix(aws-apigateway): allow multiple uses of Lambdas inAPI GW Aug 4, 2019
@eladb eladb changed the title fix(aws-apigateway): allow multiple uses of Lambdas inAPI GW fix(apigateway): allow multiple uses of lambda functions Aug 7, 2019
@eladb eladb changed the title fix(apigateway): allow multiple uses of lambda functions fix(apigateway): allow using the same lambda integration for multiple apis Aug 7, 2019
eladb
eladb previously approved these changes Aug 7, 2019
@eladb
Copy link
Contributor

eladb commented Aug 13, 2019

@hoegertn need to update decdk snapshot tests

@eladb eladb changed the title fix(apigateway): allow using the same lambda integration for multiple apis fix(apigateway): allow reusing lambda integration for multiple apis Aug 13, 2019
@mergify mergify bot merged commit 6e6440a into aws:master Aug 13, 2019
@hoegertn hoegertn deleted the multiuse-lambda-integration branch August 13, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 APIs Using LambdaIntegration for the same Lambda function throws an error
2 participants