feat(ecs-patterns): allow customizing logdriver #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kohidave please review |
piradeepk
force-pushed
the
normalizeEcsPatterns
branch
2 times, most recently
from
4a81267
to
3a34983
Compare
eladb
approved these changes
Aug 6, 2019
packages/@aws-cdk/aws-ecs-patterns/lib/base/load-balanced-service-base.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
| @@ -136,6 +160,11 @@ export abstract class QueueProcessingServiceBase extends Construct { | |||
| constructor(scope: Construct, id: string, props: QueueProcessingServiceBaseProps) { | |||
| super(scope, id); | |||
|
|
|||
There was a problem hiding this comment.
Feels like we can probably reuse this logic across patterns (via common utility function)
There was a problem hiding this comment.
Potentially, I'll leave this PR as is, and create an issue to discuss this, there's a lot of common functionality that's separated today.
eladb
approved these changes
Aug 6, 2019
eladb
changed the title
|
See my title update |
piradeepk
force-pushed
the
normalizeEcsPatterns
branch
from
c054059
to
00be984
Compare
|
Rebased with master |
kohidave
reviewed
Aug 6, 2019
packages/@aws-cdk/aws-ecs-patterns/lib/base/load-balanced-service-base.ts
Show resolved
Hide resolved
kohidave
reviewed
Aug 6, 2019
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
kohidave
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the ability to pass logdriver as a property of all ecs-patterns constructs and update all constructs to accept either a vpc or cluster.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license