fix(core): correct return type of Fn.getAtt #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was still typed as `Token` but that has become a static helper host a couple of versions ago. The actual return time is `IResolvable`. It compiled in **TypeScript** since `Token` declares no instance members, thus allowing any object to structurally cast to it -- however this would not work in strong statically typed languages such as Java, where this incurs an invalid cast.
skinny85
previously approved these changes
Aug 6, 2019
skinny85
approved these changes
Aug 6, 2019
|
Nice one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was still typed as
Tokenbut that has become a static helper hosta couple of versions ago. The actual return time is
IResolvable. Itcompiled in TypeScript since
Tokendeclares no instance members,thus allowing any object to structurally cast to it -- however this
would not work in strong statically typed languages such as Java, where
this incurs an invalid cast.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license