fix(core): fix use of references in toJsonString() #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tokens are identified to be References, leave their type unchanged in `toJsonString()`, so that they'll be properly identified as references and handled in a potentially cross-stack way. Add checking to references so that they'll be used correctly in tests.
eladb
reviewed
Aug 7, 2019
| const consumingStack = Stack.of(context.scope); | ||
| const token = this.replacementTokens.get(consumingStack); | ||
| if (!token && this.isCrossStackReference(consumingStack) && !context.preparing) { | ||
| throw new Error('Should have hadd a cross-stack reference, but not found. prepare() the reference first.'); |
There was a problem hiding this comment.
Very cryptic error and has a typo
eladb
previously approved these changes
Aug 7, 2019
eladb
previously approved these changes
Aug 7, 2019
eladb
approved these changes
Aug 8, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tokens are identified to be References, leave their type unchanged
in
toJsonString(), so that they'll be properly identified asreferences and handled in a potentially cross-stack way.
Add checking to references so that they'll be used correctly in tests.
Fixes #3474
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license