fix(asg/ec2): fix value of defaultChild
#3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AutoScalingGroup` and `Subnet` had default children with incorrect names, so that `defaultChild` would not pick them up. Add and use an override mechanism so that people can use the escape hatch more conveniently with those constructs. Fixes #3478.
eladb
reviewed
Aug 7, 2019
| * This should only be used in the cases where the correct | ||
| * default child is not named 'Resource' or 'Default' as it | ||
| * should be. | ||
| */ |
There was a problem hiding this comment.
Document what happens when undefined is set
eladb
approved these changes
Aug 8, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoScalingGroupandSubnethad default children with incorrectnames, so that
defaultChildwould not pick them up. Add and use anoverride mechanism so that people can use the escape hatch more
conveniently with those constructs.
Fixes #3478.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license