fix(ecr): set correct resource policy for ecr repository #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the aws-ecr-assets test where an IAM user receives the policy instead of the ECR repository.
rix0rrr
reviewed
Aug 9, 2019
| "Resource": "*", | ||
| "Resource": { | ||
| "Fn::GetAtt": [ | ||
| "TestHarnessRepoAA7E9724", |
There was a problem hiding this comment.
This can't work though. Will lead to a dependency cycle, as this is the GetAtt of the repository that is currently being created. Try resourceSelfArns: [].
There was a problem hiding this comment.
That's a good point, I'll look into a proper fix.
|
@rix0rrr I've implemented the change, should be good now 👍 |
eladb
approved these changes
Aug 14, 2019
rix0rrr
approved these changes
Aug 19, 2019
|
Thank you for contributing! Your pull request is now being automatically merged. |
|
Thank you for contributing! Your pull request is now being automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3583. Adding
Resource: "*"to an ECR repository policy gives the error "Invalid parameter at 'PolicyText'". According to the documentation, a proper ECR repository policy doesn't have this property. This PR removes that property.Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license