Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toolkit): conditionally emit AWS::CDK::Metadata resource #3692

Merged
merged 8 commits into from
Sep 17, 2019
Merged

feat(toolkit): conditionally emit AWS::CDK::Metadata resource #3692

merged 8 commits into from
Sep 17, 2019

Conversation

RomainMuller
Copy link
Contributor

For relocatable stacks (those where no region is provided to the
core.Stack constructor while synthesizing), generate a condition to
only try to populate the AWS::CDK::Metadata resource in regions that
are known to support it.

Fixes #3648

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@RomainMuller
feat(toolkit): conditionally emit AWS::CDK::Metadata resource
fa16735 
For relocatable stacks (those where no `region` is provided to the
`core.Stack` constructor while synthesizing), generate a condition to
only try to populate the `AWS::CDK::Metadata` resource in regions that
are known to support it.

Fixes #3648
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2019 •
edited by RomainMuller

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@RomainMuller RomainMuller requested a review from a team August 17, 2019 00:01
@aws aws deleted a comment from mergify bot Aug 17, 2019
@aws aws deleted a comment from mergify bot Aug 17, 2019
eladb
eladb previously requested changes Aug 26, 2019
View reviewed changes
packages/@aws-cdk/region-info/lib/fact.ts Outdated Show resolved Hide resolved
packages/aws-cdk/lib/api/cxapp/stacks.ts Outdated Show resolved Hide resolved
packages/aws-cdk/test/api/test.stacks.ts Show resolved Hide resolved
@mergify mergify bot dismissed eladb’s stale review August 26, 2019 12:22

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks approved these changes Sep 17, 2019
View reviewed changes
packages/@aws-cdk/region-info/lib/region-info.ts
@@ -4,6 +4,14 @@ import { Fact, FactName } from './fact';
* Information pertaining to an AWS region.
*/
export class RegionInfo {
/**
* @returns the list of names of AWS regions for which there is at least one registered fact. This
* may not be an exaustive list of all available AWS regions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exhaustive*

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2019

Thank you for contributing! Your pull request is now being automatically merged.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5901d6e into master Sep 17, 2019
@mergify mergify bot deleted the rmuller/conditional-metadata-resource branch September 17, 2019 06:44
eladb pushed a commit that referenced this pull request Sep 23, 2019
@RomainMuller
feat(toolkit): conditionally emit AWS::CDK::Metadata resource (#3692)
2eb9b8a 
* feat(toolkit): conditionally emit AWS::CDK::Metadata resource

For relocatable stacks (those where no `region` is provided to the
`core.Stack` constructor while synthesizing), generate a condition to
only try to populate the `AWS::CDK::Metadata` resource in regions that
are known to support it.

Fixes #3648

* fix typo

* use higher level primitives

* move condition name to a variable

* fix broken unit test
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr left review comments

@eladb eladb eladb left review comments

@shivlaks shivlaks shivlaks approved these changes

Assignees

@shivlaks shivlaks

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support me-south-1 region (Unrecognized resource types: [AWS::CDK::Metadata])
6 participants
@RomainMuller @aws-cdk-automation @rix0rrr @eladb @shivlaks @NGL321