Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): add support for attribute key matching in message filtering #3709

Merged
merged 5 commits into from
Sep 12, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Aug 19, 2019

SNS message filtering now supports attribute key matching. This feature lets you create an Amazon
SNS subscription filter policy that matches incoming messages which contain an attribute key,
regardless of the attribute value associated with this key. This feature lets you offload additional
message filtering logic to Amazon SNS.

Update SubscriptionFilter to support this new feature.

See https://aws.amazon.com/about-aws/whats-new/2019/08/amazon-sns-message-filtering-adds-support-for-attribute-key-matching/


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

SNS message filtering now supports attribute key matching. This feature lets you create an Amazon
SNS subscription filter policy that matches incoming messages which contain an attribute key,
regardless of the attribute value associated with this key. This feature lets you offload additional
message filtering logic to Amazon SNS.

Update `SubscriptionFilter` to support this new feature.

See https://aws.amazon.com/about-aws/whats-new/2019/08/amazon-sns-message-filtering-adds-support-for-attribute-key-matching/
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@nija-at nija-at assigned nija-at and unassigned garnaat Sep 11, 2019
@nija-at nija-at requested a review from a team September 11, 2019 14:18
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit dbf0134 into aws:master Sep 12, 2019
@jogold jogold deleted the filter-policy-attribute-key branch October 24, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants