feat(codepipeline): handle non-CFN cross-region actions #3777
Conversation
packages/@aws-cdk/aws-codepipeline/lib/full-action-descriptor.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const actionResource = action.actionProperties.resource; | ||
| if (actionResource) { | ||
| const actionResourceStack = Stack.of(actionResource); |
There was a problem hiding this comment.
should we validate that actionProperties.region is the same or undefined?
There was a problem hiding this comment.
Like I said before, I don't think that's a great idea. This could be passed by a concrete action class, which the customer has no control over, and I wouldn't be able to get rid of the validation error.
skinny85
force-pushed
the
feature/cross-region-non-cfn-actions
branch
2 times, most recently
from
75ac631
to
7b3e80a
Compare
|
Included comments & rebased on top of |
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
skinny85
force-pushed
the
feature/cross-region-non-cfn-actions
branch
from
7b3e80a
to
806ba1e
Compare
|
Rebased on top of newest |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
|
||
| const actionResource = action.actionProperties.resource; | ||
| if (actionResource) { | ||
| const actionResourceStack = Stack.of(actionResource); |
| @@ -2,6 +2,25 @@ import kms = require('@aws-cdk/aws-kms'); | |||
| import s3 = require('@aws-cdk/aws-s3'); | |||
| import cdk = require('@aws-cdk/core'); | |||
|
|
|||
| export class CrossRegionSupportConstruct extends cdk.Construct { | |||
There was a problem hiding this comment.
Remove the "Construct" posfix: CrossRegionSupport
There was a problem hiding this comment.
That I can't do: that name is already taken (by the customer-facing interface that's returned from the Pipeline's class crossRegionSupport method). CrossRegionSupportConstruct is private to the codepipeline package.
skinny85
force-pushed
the
feature/cross-region-non-cfn-actions
branch
from
806ba1e
to
21c0b7f
Compare
|
Rebased and included last comment. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Adds support for actions other than the CloudFormation ones to be cross-region. It works similarly to the cross-account support: passing a resource from a different region into a CodePipeline action makes the action implicitly cross-region. Closes #3387
Adds support for actions other than the CloudFormation ones to be cross-region.
It works similarly to the cross-account support: passing a resource from a different region into a CodePipeline action makes the action implicitly cross-region.
Closes #3387
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license