feat(ecs,lambda,rds): specify allowAllOutbound when importing security groups

[jogold]

Some imported resource were not included in #3386.

BREAKING CHANGE: securityGroupId: string replaced by securityGroup: ISecurityGroup when importing a cluster/instance in @aws-cdk/aws-rds

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[jogold]

I suspect there's also something to do here:

aws-cdk/packages/@aws-cdk/aws-ecs/lib/cluster.ts

Lines 585 to 587 in 3a0cde0

	for (const sgProps of props.securityGroups) {
	this.connections.addSecurityGroup(ec2.SecurityGroup.fromSecurityGroupId(this, `SecurityGroup${i}`, sgProps.securityGroupId));
	i++;

but this import takes a ec2.ISecurityGroup[] which means that there's some sort of double import here...

[mergify]

Pull Request Checklist

• Testing

• Unit test added (prefer to add a new test rather than modify existing tests)
• CLI change? Re-run/add CLI integration tests

• Documentation

• Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
• README: update module README
• Design: for significant features, follow the design process

• Title uses the format type(scope): text

• Type: fix, feat, refactor go into CHANGELOG, chore is hidden
• Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
• Style: use all lower-case, do not end with a period

• Description

• Rationale: describe rationale of change and approach taken
• Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
• Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>

• Sensitive Modules (requires 2 PR approvers)

• IAM document library (in @aws-cdk/aws-iam)
• EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
• Grant APIs (if not based on official documentation with a reference)

[eladb]

Test please.

[eladb]

I feel like the right thing would have been to specify ISecurityGroup instead of a security group ID but this ship has sailed...

[jogold]

How about deprecating in favor of a securityGroup: ISecurityGroup?

[eladb]

Yes!

Pull request has been modified.

[eladb]

same

[mergify]

Thank you for contributing! Your pull request is now being automatically merged.

[jogold]

@eladb I added the BREAKING CHANGE in the last commit message to be sure that when mergify squashes it gets taken into account, hope this will work.

[mergify]

Thank you for contributing! Your pull request is now being automatically merged.