Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): environment var values are strings #3858

Merged
merged 7 commits into from
Aug 29, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Aug 29, 2019

AWS Lambda requires that all environment variables will be
strings but the API indicated any as the type of the value.
If users would pass in a non-string value, they would see an
error only during deployment.

Fixes #3337


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

AWS Lambda requires that all environment variables will be
strings but the API indicated `any` as the type of the value.
If users would pass in a non-string value, they would see an
error only during deployment.

Fixes #3337
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

shivlaks
shivlaks previously approved these changes Aug 29, 2019
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not breaking because non string values never worked right?

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

rix0rrr
rix0rrr previously approved these changes Aug 29, 2019
@mergify mergify bot dismissed stale reviews from shivlaks and rix0rrr August 29, 2019 09:41

Pull request has been modified.

rix0rrr
rix0rrr previously approved these changes Aug 29, 2019
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to list breaking changes in commit message.

@eladb
Copy link
Contributor Author

eladb commented Aug 29, 2019

@rix0rrr technically this can’t break anyone because non-string values never worked

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify mergify bot dismissed rix0rrr’s stale review August 29, 2019 10:24

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit f892312 into master Aug 29, 2019
@mergify mergify bot deleted the benisrae/lambda-env-type branch August 29, 2019 12:56
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lambda.Function.addEnvironment appears to only accept string type values
4 participants