Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(events): remove custom resource for fargate event target #3952

Merged
merged 5 commits into from
Sep 11, 2019
Merged

fix(events): remove custom resource for fargate event target #3952

merged 5 commits into from
Sep 11, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 5, 2019 •
edited by eladb

The latest CloudFormation specification adds LaunchType and NetworkConfiguration properties to the EcsParameters property. A custom resource to set those values is no longer needed.

Closes #3930

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
chore(events): remove custom resource for fargate event target
f0a9e46 
The latest CloudFormation specification adds `LaunchType` and `NetworkConfiguration` properties to
the `EcsParameters` property. A custom resource to set those values is no longer needed.

Closes aws#3930
@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@eladb eladb changed the title chore(events): remove custom resource for fargate event target fix(events): remove custom resource for fargate event target Sep 11, 2019
eladb
eladb previously approved these changes Sep 11, 2019
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot dismissed eladb’s stale review September 11, 2019 07:19

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2019

Continuous integration build failed

eladb
eladb previously approved these changes Sep 11, 2019
View reviewed changes
@mergify mergify bot dismissed eladb’s stale review September 11, 2019 07:23

Pull request has been modified.

@jogold jogold requested a review from eladb September 11, 2019 07:24
@mergify mergify bot merged commit 920f12f into aws:master Sep 11, 2019
@jogold jogold deleted the cfn-ecs-target branch September 11, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove custom resource implementation for Fargate event target
3 participants
@jogold @eladb @rix0rrr