Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): json schema additionalProperties should be boolean #3997

Merged

Conversation

daiwei920
Copy link
Contributor

@daiwei920 daiwei920 commented Sep 9, 2019

In JSON schema, additionalProperties is a boolean and not another schema.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

eladb
eladb previously requested changes Sep 9, 2019
packages/@aws-cdk/aws-apigateway/lib/json-schema.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed eladb’s stale review September 9, 2019 10:46

Pull request has been modified.

eladb
eladb previously requested changes Sep 9, 2019
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review and follow the pull request checklist?

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify mergify bot dismissed eladb’s stale review September 11, 2019 07:16

Pull request has been modified.

@eladb eladb changed the title Add support for json schema additionalProperties fix(apigateway): json schema additionalProperties should be boolean Sep 11, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2019

Thank you for contributing! Your pull request is now being automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants