Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize packages/ #4

Closed
eladb opened this issue May 31, 2018 · 3 comments
Closed

Reorganize packages/ #4

eladb opened this issue May 31, 2018 · 3 comments
Assignees

Comments

@eladb
Copy link
Contributor

eladb commented May 31, 2018

The current flat structure of our monorepo makes it hard to work with it as it's hard to scope down lerna operations only to certain parts of it. Eventually, once we start publishing to NPM, we will want to manage various module (or module groups) in separate repos, but for now, let's try to organize it in a way that will make it more practical to use.

Here's an initial proposal:

packages/framework
    aws-cdk
    aws-cdk-applet-js
    aws-cdk-assert
    aws-cdk-cloudformation-diff
    aws-cdk-custom-resources
    aws-cdk-cx-api
    aws-cdk-resources
    aws-cdk-toolkit
    aws-cdk-util
packages/awslibs
    aws-cdk-acm
    aws-cdk-cloudtrail
    aws-cdk-codebuild
    aws-cdk-codecommit
    aws-cdk-codepipeline
    aws-cdk-dynamodb
    aws-cdk-ec2
    aws-cdk-events
    aws-cdk-iam
    aws-cdk-kms
    aws-cdk-lambda
    aws-cdk-neptune
    aws-cdk-quickstarts
    aws-cdk-rds
    aws-cdk-route53
    aws-cdk-rtv
    aws-cdk-s3
    aws-cdk-sns
    aws-cdk-sqs
packages/build-tools
    cfn2ts
    pkglint
    pkgtools
    simple-resource-bundler
packages/bundles
    cdk-bundle-all
    cdk-bundle-docs
    cdk-bundle-java
packages/examples
@eladb
Copy link
Contributor Author

eladb commented May 31, 2018

We also need to take into account the fact that we are going to move all modules to the "@aws-cdk" scope. I wonder if this is orthogonal to the directory structure or lerna requires that scopes will be represented by the tree structure as well

@rix0rrr
Copy link
Contributor

rix0rrr commented May 31, 2018

Don't really care for the name awslibs, agreed on all the rest.

I don't think the source directory structure has to mirror the scopes--the node_modules install path definitely will and that's all that's necessary for require() to work--but we might as well name the directory @aws-cdk/ anyway. It's nice and clear and avoids us having to think of a good name for the directory :P

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 22, 2018

Turns out we did most of this and it seems to be fine for now. Closing.

@rix0rrr rix0rrr closed this as completed Jun 22, 2018
john-shaskin added a commit to john-shaskin/aws-cdk that referenced this issue Jan 18, 2019
# This is the 1st commit message:

Add MethodResponse support for aws-apigateway

# This is the commit message aws#2:

Remove Dockerfile that was no longer needed

# This is the commit message aws#3:

Update python base image from 3.6 to 3.6.5

# This is the commit message aws#4:

Make the dockerfile work
john-shaskin added a commit to john-shaskin/aws-cdk that referenced this issue Jan 18, 2019
# This is the 1st commit message:

Add MethodResponse support for aws-apigateway

# This is the commit message aws#2:

Remove Dockerfile that was no longer needed

# This is the commit message aws#3:

Update python base image from 3.6 to 3.6.5

# This is the commit message aws#4:

Make the dockerfile work
smguggen referenced this issue in smguggen/aws-cdk Aug 24, 2021
# This is the 1st commit message:

Add Identity Pool construct

# This is the commit message #2:

Bug fixes

# This is the commit message #3:

Bug fixes

# This is the commit message #4:

Formatting

# This is the commit message #5:

Add construct methods

# This is the commit message #6:

Remove flat

# This is the commit message #7:

Fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants