Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route53): remove http:// from bucket target #4070

Merged
merged 6 commits into from
Sep 18, 2019
Merged

fix(route53): remove http:// from bucket target #4070

merged 6 commits into from
Sep 18, 2019

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Sep 13, 2019

  • change bucket type to IBucket to allow static import

Fixes #3928

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fix(route53-targets): remove http:// from bucket target
f7707b3 
* change bucket type to IBucket to allow static import
@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title fix(route53-targets): remove http:// from bucket target fix(route53): remove http:// from bucket target Sep 13, 2019
eladb
eladb previously approved these changes Sep 13, 2019
View reviewed changes
@hoegertn
Copy link
Contributor

Are you sure the regional domain same has the same semantic as the website url with regards to website hosting?

@nmussy
Copy link
Contributor Author

nmussy commented Sep 13, 2019

Good catch @hoegertn, you're right, it doesn't include s3-website-. I was about to mess it up again, thanks.

I'll look into it truncating the websiteURL property a little later then. @eladb Can you block this PR in the meantime?

@hoegertn
Copy link
Contributor

I am currently working on a PR for r53 redirects. Within this pr I added a websiteDomainName attribute to the bucket. Maybe this would help once it is merged...

@nmussy
Copy link
Contributor Author

nmussy commented Sep 13, 2019

Yeah, websiteDomainName from #3946 looks perfect. I'll hold up until it's merged, thanks again.

@eladb eladb added the pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. label Sep 14, 2019
@eladb eladb self-assigned this Sep 16, 2019
@nmussy
Copy link
Contributor Author

nmussy commented Sep 17, 2019

@eladb Should be good for review 👍

@mergify mergify bot dismissed eladb’s stale review September 17, 2019 07:30

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@hoegertn
Copy link
Contributor

I am not sure about the second test. SHouldn't the Join contain http://? Otherwise, the split will fail...

@nmussy
Copy link
Contributor Author

nmussy commented Sep 17, 2019

@hoegertn Would that an issue with #3946 then? Because I'm only using fromBucketName there.

@hoegertn
Copy link
Contributor

You are right this is a bug in the Bucket, and I just used the existing websiteUrl property but it is incorrect for imported buckets. see #4113

eladb
eladb previously approved these changes Sep 18, 2019
View reviewed changes
@eladb eladb removed the pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. label Sep 18, 2019
@mergify mergify bot dismissed eladb’s stale review September 18, 2019 10:32

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 621441d into aws:master Sep 18, 2019
eladb pushed a commit that referenced this pull request Sep 23, 2019
fix(route53): remove http:// from bucket target (#4070)
8760359 
* fix(route53-targets): remove `http://` from bucket target
* change bucket type to IBucket to allow static import

* chore: tslint fix

* fix: use bucketWebsiteDomainName property

* chore: remove unnecessary quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@shivlaks shivlaks Awaiting requested review from shivlaks

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

route53 A record is setting incorrect alias target for s3 website
4 participants
@nmussy @aws-cdk-automation @hoegertn @eladb