Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(acm): on delete, wait for certificate to become unused #4191

Merged
merged 3 commits into from
Sep 26, 2019
Merged

fix(acm): on delete, wait for certificate to become unused #4191

merged 3 commits into from
Sep 26, 2019

Conversation

jonathanmorley
Copy link
Contributor

wait for certificates to be unused before deleting them
fixes #4179

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@jonathanmorley
fix(certificatemanager): only delete unused certificates
7d1925d 
wait for DNS validated cert to be unused before deleting
fixes aws#4179
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr
rix0rrr reviewed Sep 25, 2019
View reviewed changes
...ws-cdk/aws-certificatemanager/lambda-packages/dns_validated_certificate_handler/lib/index.js Outdated

let inUseByResources;
const maxAttempts = 10;
for (let attempt = 0; attempt < maxAttempts - 1; attempt++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean attempt < maxAttempts, not attempt < maxAttempts - 1.

Consider what happens if maxAttempts = 1. The following would happen:

for (let attempt = 0; attempt < 0; attempt++) {
}

And the loop body would not be executed at all.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title fix(certificatemanager): only delete unused certificates fix(acm): on delete, wait for certificate to become unused Sep 26, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit db77bfe into aws:master Sep 26, 2019
alukach pushed a commit to alukach/aws-cdk that referenced this pull request Nov 1, 2019
@jonathanmorley @alukach
fix(acm): on delete, wait for certificate to become unused (aws#4191)
83d1e07 
* fix(certificatemanager): only delete unused certificates

wait for DNS validated cert to be unused before deleting
fixes aws#4179

* fix(certificatemanager): fix maxAttempts logic in DNS validated certs when equal to 1
@grbartel grbartel mentioned this pull request Aug 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

certificate-manager: Unable to delete DnsValidatedCertificates that are still attached to resources
3 participants
@jonathanmorley @aws-cdk-automation @rix0rrr