fix(acm): support Tokens for domainName in Certificate #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect when someone tries to use a Token for a `domainName` in `Certificate`, and require that they supply a validation domain when that happens (necessary because we won't be able to properly calculate the apex domain at CDK run time). This does require that you use the exact same string in the `validationDomains` map; since different instances of equivalent tokens might evaluate to a different string, this requires that you store the stringified token in a variable first. Fixes #4232.
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Sep 27, 2019
RomainMuller
approved these changes
Sep 27, 2019
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect when someone tries to use a Token for a
domainNameinCertificate, and require that they supply a validation domain whenthat happens (necessary because we won't be able to properly calculate
the apex domain at CDK run time).
This does require that you use the exact same string in the
validationDomainsmap; since different instances of equivalenttokens might evaluate to a different string, this requires that you
store the stringified token in a variable first.
Fixes #4232.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license