Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codepipeline): validate that source actions are in the same region as the pipeline #4303

Merged
merged 2 commits into from
Oct 1, 2019
Merged

feat(codepipeline): validate that source actions are in the same region as the pipeline #4303

merged 2 commits into from
Oct 1, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Oct 1, 2019

This is something that the CodePipeline API enforces in the backend,
so we should validate it before, at synthesis time.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85
feat(codepipeline): validate that source actions are in the same regi…
7bcd58d 
…on as the pipeline

This is something that the CodePipeline API enforces in the backend,
so we should validate it before, at synthesis time.
@skinny85 skinny85 requested a review from rix0rrr October 1, 2019 01:01
@skinny85 skinny85 self-assigned this Oct 1, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c35091f into aws:master Oct 1, 2019
@skinny85 skinny85 deleted the fix/validate-source-action-is-in-same-region-as-pipeline branch October 1, 2019 19:19
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@skinny85 skinny85

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skinny85 @aws-cdk-automation @rix0rrr @SomayaB