Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DbClusterFromSnapshot construct #4379

Closed
2 tasks
cseickel opened this issue Oct 4, 2019 · 5 comments · Fixed by #10130
Closed
2 tasks

Add DbClusterFromSnapshot construct #4379

cseickel opened this issue Oct 4, 2019 · 5 comments · Fixed by #10130
Assignees
@njlynch
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Milestone
[GA] RDS

Comments

@cseickel
Copy link

cseickel commented Oct 4, 2019

Please create a DbClusterInstanceFromSnapshot construct like the DatabaseInstanceFromSnapshot that already exists, which would support Aurora Databases.

Use Case

I need the ability to clone an Aurora MySQL production database into a new environment as part of testing and release procedures.

Without CDK support, I am forced to script the restore from a mysql dump file in the UserData script of a bastion host. This is clunky.

Proposed Solution

Create a DbClusterInstanceFromSnapshot construct that works for Aurora.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@cseickel cseickel added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 4, 2019
@NGL321 NGL321 added @aws-cdk/aws-rds Related to Amazon Relational Database and removed needs-triage This issue or PR still needs to be triaged. labels Oct 4, 2019
@NGL321
Copy link
Contributor

NGL321 commented Oct 4, 2019

Hey @cseickel,

Thanks for contributing! This seems like a pretty reasonable ask.
Someone will look into it and update this issue when there is any movement

@skinny85
Copy link
Contributor

skinny85 commented Feb 6, 2020

@cseickel is this what you were looking for?

Thanks,
Adam

@skinny85 skinny85 added guidance Question that needs advice or information. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed feature-request A feature should be added or improved. labels Feb 6, 2020
@skinny85 skinny85 assigned nija-at and unassigned skinny85 Feb 6, 2020
@cseickel
Copy link
Author

cseickel commented Feb 7, 2020

@skinny85 no, that is not what I was asking for at all. I was asking for the ability to restore a Cluster from snapshot, not an Instance. What you linked to would not work for Aurora.

@skinny85
Copy link
Contributor

skinny85 commented Feb 7, 2020

Ah, got it. Thanks for the explanation @cseickel .

@nija-at nija-at added feature-request A feature should be added or improved. effort/large Large work item – several weeks of effort and removed guidance Question that needs advice or information. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Feb 12, 2020
@sebsonjura
Copy link

Uh, this one would be 'very nice', as it is possible via the UI and apretty usable feature to do things like

'please spin me up a second, serverless variant, of our production AURORA CLUSTER' ...

@skinny85 skinny85 added this to the RDS to 'stable' milestone Jul 8, 2020
@nija-at nija-at assigned skinny85 and unassigned nija-at Jul 14, 2020
@srethira srethira mentioned this issue Jul 29, 2020
Closed
@skinny85 skinny85 added the p2 label Aug 19, 2020
@njlynch njlynch assigned njlynch and unassigned skinny85 Sep 1, 2020
njlynch added a commit that referenced this issue Sep 2, 2020
@njlynch
feat(rds): database clusters from snapshots
d0dfa1b 
Created the `DatabaseClusterFromSnapshot` to support creating database clusters
from snapshots.

I made some intentional decisions here to avoid exposing as much of the
underlying "base" classes and interfaces as possible, to support future
refactoring as necessary.

fixes #4379
@njlynch njlynch mentioned this issue Sep 2, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 3, 2020
@mergify mergify bot closed this as completed in #10130 Sep 4, 2020
mergify bot pushed a commit that referenced this issue Sep 4, 2020
@njlynch
feat(rds): database clusters from snapshots (#10130)
915eb4b 
Created the `DatabaseClusterFromSnapshot` to support creating database clusters
from snapshots.

I made some intentional decisions here to avoid exposing as much of the
underlying "base" classes and interfaces as possible, to support future
refactoring as necessary.

fixes #4379


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[GA] RDS
Development

Successfully merging a pull request may close this issue.

feat(rds): database clusters from snapshots aws/aws-cdk
7 participants
@skinny85 @njlynch @NGL321 @cseickel @nija-at @SomayaB @sebsonjura