Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): add family name to queue processing service properties #4508

Merged
merged 7 commits into from
Oct 18, 2019
Merged

feat(ecs-patterns): add family name to queue processing service properties #4508

merged 7 commits into from
Oct 18, 2019

Conversation

pkspks
Copy link

@pkspks pkspks commented Oct 15, 2019

Add support for specifying ECS task definition family name in queue processing ECS service constructs
Fixes #4507

Use Case

Task family names group versions of task definitions.
QueueProcessingEc2Service and QueueProcessingFargateService don't support providing service name when constructing the services.

Proposed Solution

Add optional taskDefinitionFamily: String in QueueProcessingServiceBaseProps.ts and use it when creating services in QueueProcessingEc2Service.ts and QueueProcessingFargateService.ts
This approach does not break existing code.

Not sure about the direction in which we want this to head but another approach may be to introduce taskImageOptions: QueueProcessingTaskImageOptions ala NetworkLoadBalancedTaskImageOptions and ApplicationLoadBalancedTaskImageOptions and move task and image related attributes from QueueProcessingServiceBaseProps to QueueProcessingTaskImageOptions.
This will affect attributes like image, logDriver, 'environment', 'secrets' but will move QueueProcessingServiceBase closer to other implementations.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pkspks pkspks requested a review from SoManyHs as a code owner October 15, 2019 03:53
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@pkspks pkspks force-pushed the features/ecs-patterns-queue-processing-task-family branch from cc4e3c3 to aadc3e3 Compare October 15, 2019 03:55
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Oct 15, 2019
@dependabot-preview
feat(ecs-patterns): add support for specifying ECS task definition fa…
36894c2 
…mily name in queue processing ECS service constructs (aws#4507)
@pkspks pkspks force-pushed the features/ecs-patterns-queue-processing-task-family branch from aadc3e3 to 36894c2 Compare October 15, 2019 22:04
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk
piradeepk previously requested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this PR! Thanks for taking the time to contribute!

packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed piradeepk’s stale review October 17, 2019 22:11

Pull request has been modified.

@piradeepk piradeepk changed the title feat(ecs-patterns): add support for specifying ECS task definition family name in queue processing ECS service constructs (#4507) feat(ecs-patterns): add task definition family name to queue processing service constructs Oct 17, 2019
@piradeepk piradeepk changed the title feat(ecs-patterns): add task definition family name to queue processing service constructs feat(ecs-patterns): add family name to queue processing service properties Oct 17, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk
piradeepk approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! Thanks for taking the time to add this feature!

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b0874bb into aws:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piradeepk piradeepk piradeepk approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for task definition family name for queue processing ECS services
5 participants
@pkspks @aws-cdk-automation @piradeepk @SomayaB @SoManyHs