Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudfront): expose CfnDistribution as defaultChild #4556

Merged
merged 4 commits into from
Oct 17, 2019
Merged

fix(cloudfront): expose CfnDistribution as defaultChild #4556

merged 4 commits into from
Oct 17, 2019

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Oct 17, 2019

Fixes #4555

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nmussy nmussy requested a review from eladb as a code owner October 17, 2019 09:34
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@nmussy nmussy changed the title fix(cloudfront): export CfnDistribution as defaultChild fix(cloudfront): expose CfnDistribution as defaultChild Oct 17, 2019
nmussy
nmussy commented Oct 17, 2019
View reviewed changes
packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts
@@ -697,6 +697,7 @@ export class CloudFrontWebDistribution extends cdk.Construct implements IDistrib
}

const distribution = new CfnDistribution(this, 'CFDistribution', { distributionConfig });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be "cleaner" to change CFDistribution to Resource, but I'm not sure it's worth the ID change.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nmussy
Copy link
Contributor Author

nmussy commented Oct 17, 2019 •
edited

That's a weird place to break an existing test. Perhaps an issue with @aws-cdk/assert?

EDIT: I've just noticed the diff:

-"expires": "Thu, 17 Oct 2019 21:56:00 GMT"
+"expires": "Thu, 17 Oct 2019 21:56:01 GMT"

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nmussy
Copy link
Contributor Author

nmussy commented Oct 17, 2019

🤷‍♂

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8a79cad into aws:master Oct 17, 2019
@sumodgeorge sumodgeorge mentioned this pull request May 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudFront: CloudFrontWebDistribution defaultChild
3 participants
@nmussy @aws-cdk-automation @eladb