Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for us-iso partitions and regions #4669

Closed
2 tasks
troyaws opened this issue Oct 24, 2019 · 3 comments · Fixed by #7876
Closed
2 tasks

Add support for us-iso partitions and regions #4669

troyaws opened this issue Oct 24, 2019 · 3 comments · Fixed by #7876
Assignees
@fulghum
Labels
@aws-cdk/region-info Related to AWS Region information feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@troyaws
Copy link

troyaws commented Oct 24, 2019

Add support for us-iso and us-iso-b partitions and all included regions.

Use Case

Customers in these partitions/regions want the ability to utilize CDK for their workloads.

Proposed Solution

update https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/region-info/build-tools/generate-static-data.ts

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@troyaws troyaws added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 24, 2019
@RomainMuller
Copy link
Contributor

Hey,

In order to proceed, we will need the following:

  • The list of region IDs (pretty sure we can find those ourselves somewhat easily, but if you have them handy...)
  • The correct name of the Service Principals at least for the following services (unless of course they're not available in us-iso and us-iso-b):
    • application-autoscaling
    • autoscaling
    • codedeploy
    • ec2
    • events
    • lambda
    • logs
    • s3
    • sns
    • sqs
    • states
  • If Route53 is available (I have doubts, but 🤷🏻‍♂️), the Route53 hosted zone IDs for the S3 static websites & API Gateway edge-optimized endpoints

Also, if you have a know set of things that does not currently work, it would help if you can provide some information on those, so we can make sure that the above information actually covers the entire gap, and not just a part of it (the isolated regions are... peculiar enough to possibly trigger scenarios we haven't encountered yet).

@RomainMuller RomainMuller added the @aws-cdk/region-info Related to AWS Region information label Oct 24, 2019
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Oct 24, 2019
@nmussy
Copy link
Contributor

nmussy commented Oct 26, 2019

The publicly available documentation on the secret regions are a bit sparse.

The only useful info I could find was aws-sdk-go endpoints.json's file

@awsjoe
Copy link

awsjoe commented Nov 5, 2019

That's as good a place to start as any, what more would be required for the fulfillment of this issue?

@RomainMuller RomainMuller assigned eladb and unassigned RomainMuller Jan 24, 2020
@eladb eladb assigned fulghum and unassigned eladb Jan 26, 2020
@joel-aws joel-aws mentioned this issue May 8, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label May 11, 2020
@mergify mergify bot closed this as completed in #7876 May 18, 2020
mergify bot pushed a commit that referenced this issue May 18, 2020
@joel-aws
feat(region-info): add information for us-gov, us-iso, and us-isob re…
afe0b00 
…gions

### Commit Message
feat(region-info): add information for us-gov, us-iso, and us-isob regions (#7876)

`us-gov`, `us-iso`, and `us-isob` regions have additional information and formatting, to include:

* Service Principal names.
* S3 static website endpoints and Route 53 Hosted Zone IDs (when available).
* VPC endpoint service name prefixes.

Fixes #4669
### End Commit Message

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
karupanerura pushed a commit to karupanerura/aws-cdk that referenced this issue May 22, 2020
@joel-aws @karupanerura
feat(region-info): add information for us-gov, us-iso, and us-isob re…
7aad9cd 
…gions

### Commit Message
feat(region-info): add information for us-gov, us-iso, and us-isob regions (aws#7876)

`us-gov`, `us-iso`, and `us-isob` regions have additional information and formatting, to include:

* Service Principal names.
* S3 static website endpoints and Route 53 Hosted Zone IDs (when available).
* VPC endpoint service name prefixes.

Fixes aws#4669
### End Commit Message

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fulghum fulghum

Labels
@aws-cdk/region-info Related to AWS Region information feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(region-info): add information for us-gov, us-iso, and us-isob regions
7 participants
@fulghum @RomainMuller @eladb @nmussy @troyaws @SomayaB @awsjoe