Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EncryptionKeyAlias implement EncryptionKeyRef #52

Closed
rix0rrr opened this issue Jun 6, 2018 · 1 comment · Fixed by #3694
Closed

Make EncryptionKeyAlias implement EncryptionKeyRef #52

rix0rrr opened this issue Jun 6, 2018 · 1 comment · Fixed by #3694
Assignees
@skinny85
Labels
@aws-cdk/aws-kms Related to AWS Key Management feature-request A feature should be added or improved.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 6, 2018

We want to refer to keys by alias, so that we can rotate the key.

However, we need to be able to get an ARN from the alias, and we need to be able to add policies to the original key.
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 29, 2018

Complication: in policies, the ACTUAL key's ARN should be used.

@rix0rrr rix0rrr mentioned this issue Jun 29, 2018
Closed
@eladb eladb added enhancement @aws-cdk/aws-kms Related to AWS Key Management labels Dec 17, 2018
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
@skinny85 skinny85 mentioned this issue Aug 17, 2019
Merged
skinny85 added a commit that referenced this issue Sep 11, 2019
@skinny85
feat(codepipeline): cross-environment (account+region) actions (#3694)
69bff3d 
This changes the scaffolding stack logic for the cross-region CodePipelines to include a KMS key and alias as part of it, which are required if an action is simultaneously cross-region and cross-account. We also change to use the KMS key ID instead of the key ARN when rendering the ArtifactStores property.

We also add an alias to the default pipeline artifact bucket.

This required a bunch of changes to the KMS and S3 modules:

* Alias now implements IKey
* Added the keyId property to IKey
* Added removalPolicy property to Alias
* Granting permissions to a key works if the principal belongs to a stack that is a dependent of the key stack
* Allow specifying a key when importing a bucket

Fixes #52
Concerns #1584
Fixes #2517
Fixes #2569
Concerns #3275
Fixes #3138
Fixes #3388
@jpSimkins jpSimkins mentioned this issue Oct 1, 2020
Closed
@jpSimkins jpSimkins mentioned this issue Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-kms Related to AWS Key Management feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codepipeline): cross-environment (account+region) actions skinny85/aws-cdk
4 participants
@skinny85 @rix0rrr @eladb @srchase