Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IStage#grantPipelineBucketReadWrite's one parameter optional #567

Closed
skinny85 opened this issue Aug 14, 2018 · 3 comments
Closed

Make IStage#grantPipelineBucketReadWrite's one parameter optional #567

skinny85 opened this issue Aug 14, 2018 · 3 comments

Comments

@skinny85
Copy link
Contributor

In #459, it was not possible to make IStage#grantPipelineBucketReadWrite's parameter optional because of a bug in JSII. Once that bug is fixed, we should change the parameter to be optional.
@skinny85 skinny85 mentioned this issue Aug 14, 2018
Merged
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 17, 2018

Is this fixed now?

@skinny85
Copy link
Contributor Author

The JSII bug this was depending on was recently fixed (and the version of JSII bumped in CDK), but the actual issue in the CodePipeline construct has not been addressed yet.

@skinny85
Copy link
Contributor Author

skinny85 commented Nov 7, 2018

Done as a side-effect of #1026.

@skinny85 skinny85 closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skinny85 @rix0rrr