Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Fix various init templates & their tests #5693

Merged
merged 2 commits into from Jan 15, 2020
Merged

fix(cli): Fix various init templates & their tests #5693

merged 2 commits into from Jan 15, 2020

Conversation

netroy
Copy link
Contributor

@netroy netroy commented Jan 7, 2020

These changes were missing in #3261
I couldn't find any relevant tests for templates.
Perhaps there should be tests for these??

fixes #5565

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks reviewed Jan 7, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relevant tests for the init templates are in this integ test folder - https://github.com/aws/aws-cdk/tree/master/packages/aws-cdk/test/integ/init

can you verify that these run successfully (running just test-all should be sufficient)

@shivlaks shivlaks changed the title fix(python): Make sure stack name does not contain illegal characters fix(init-templates): Make sure stack name does not contain illegal characters for Python templates Jan 7, 2020
shivlaks
shivlaks previously requested changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify tests

@mergify mergify bot dismissed shivlaks’s stale review January 8, 2020 11:39

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@netroy
Copy link
Contributor Author

netroy commented Jan 8, 2020

So, this took longer than expected, because I realized that a lot of init tests were broken.
all the tests were using -t to pass the template-name, while template-name needed to be the first parameter instead. So, all the tests actually ran only for template app.
This is fixed in the first commit.
The second commit fixes all the templates for sample-app & lib that have been broken all this while.

@shivlaks Can you please look at this again? Thanks.

@netroy netroy changed the title fix(init-templates): Make sure stack name does not contain illegal characters for Python templates fix(cli): Fix various init templates & their tests Jan 8, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@netroy netroy requested a review from shivlaks January 14, 2020 17:23
@mergify mergify bot dismissed shivlaks’s stale review January 14, 2020 17:25

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit a85da79 into aws:master Jan 15, 2020
@netroy netroy deleted the fix-5565 branch January 15, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdk synth and pytest errors from cdk init sample-app —language python
3 participants
@netroy @aws-cdk-automation @shivlaks