fix(ecs): cannot separate Cluster and Ec2Service behind ALB
#5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
requested review from
RomainMuller,
skinny85,
eladb,
iliapolo,
MrArnoldPalmer,
nija-at,
SoManyHs and
piradeepk
In the case of an ECS Service runningon EC2 capacity, pointing a Load Balancer to the Service involves updating the SecurityGroups of the capacity associated to the Cluster (to allow traffic from the Load Balancer). If these resources are in different stacks, this is liable to create cyclic references: Service points to Cluster, Security Groups point to Load Balancer, cyclic references arise from the way these resources are typically colocated. This changes makes it so the ingress/egress rules will be created in the same stack as the Service (which points to both Cluster and LB), hence making sure there are no cycles.
rix0rrr
force-pushed
the
huijbers/x-stack-cluster
branch
from
89dc087
to
c43d43f
Compare
rix0rrr
changed the title
Cluster and Ec2Service behind ALB
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Jan 15, 2020
|
Thank you for contributing! Your pull request is now being automatically merged. |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Sadly this broke my deployment. And as there is no way to revert to the old behaviour (from what I can tell), I am not sure what to do :D Created a bug report to explain my use-case. Hopefully you can give it a look? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of an ECS Service runningon EC2 capacity, pointing a Load
Balancer to the Service involves updating the SecurityGroups of the
capacity associated to the Cluster (to allow traffic from the Load
Balancer).
If these resources are in different stacks, this is liable to create
cyclic references: Service points to Cluster, Security Groups point
to Load Balancer, cyclic references arise from the way these resources
are typically colocated.
This changes makes it so the ingress/egress rules will be created in
the same stack as the Service (which points to both Cluster and LB),
hence making sure there are no cycles.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license